Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start nodeinfo v2.2 development #74

Merged
merged 2 commits into from
Dec 6, 2023
Merged

start nodeinfo v2.2 development #74

merged 2 commits into from
Dec 6, 2023

Conversation

6543
Copy link
Contributor

@6543 6543 commented Dec 4, 2023

  • copy "2.1" to "3.0"
  • adjust current version and add test for it

@6543 6543 mentioned this pull request Dec 4, 2023
@jhass
Copy link
Owner

jhass commented Dec 5, 2023

Mmh, I was roughly thinking to follow SemVer, that is major version increase only if a field is removed, its datatype changed or semantic meaning changed substantially. Extending the schema by adding fields so far we've been handling with minor version increments.

So I'd say let's go with 2.2 and we can always release it as 3.0 if warranted. What do you think?

@6543 6543 mentioned this pull request Dec 6, 2023
7 tasks
@6543 6543 changed the title start nodeinfo v3.0 development WIP: start nodeinfo v2.2 development Dec 6, 2023
6543 added 2 commits December 6, 2023 12:22
copy "2.1" to "2.2"
by adjust current version and add test for it
@6543 6543 changed the title WIP: start nodeinfo v2.2 development start nodeinfo v2.2 development Dec 6, 2023
@6543
Copy link
Contributor Author

6543 commented Dec 6, 2023

@jhass done 🚀

@jhass
Copy link
Owner

jhass commented Dec 6, 2023

🍪

@jhass jhass merged commit 4150d92 into jhass:main Dec 6, 2023
1 check passed
@6543 6543 deleted the nodeinfo_v3.0 branch December 6, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants